Issue 22634003: Replaced strerror() calls with threadsafe strerror_r()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22634003: Replaced strerror() calls with threadsafe strerror_r() (Closed)

Created:
7 years, 4 months ago by Chris Bracken

Modified:
7 years, 4 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Replaced strerror() calls with threadsafe strerror_r(). Mac/Android use the XSI-compliant definition of strerror_r() which stores the message in the passed-in buffer. Linux uses the GNU-specific definition of strerror_r() which takes a buffer and returns the message in a char* (which may or may not be the passed-in buffer). BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25943

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+176 lines, -46 lines)			Patch
M	runtime/bin/dbg_connection_macos.cc	View	4 chunks	+16 lines, -4 lines	0 comments	Download
M	runtime/bin/eventhandler_android.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	4 chunks	+16 lines, -4 lines	0 comments	Download
M	runtime/bin/file_android.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/file_linux.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/process_android.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View	4 chunks	+16 lines, -4 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	5 chunks	+19 lines, -5 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	4 chunks	+16 lines, -4 lines	0 comments	Download
M	runtime/bin/utils_android.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/bin/utils_linux.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/bin/utils_macos.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/platform/thread_android.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/platform/thread_linux.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/platform/thread_macos.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Bracken

7 years, 4 months ago (2013-08-08 20:24:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25943 (presubmit successful).

Expand Messages | Collapse Messages