Replaced strerror() calls with threadsafe strerror_r()

runtime/bin/socket_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include <errno.h>  // NOLINT
 #include <stdio.h>  // NOLINT
 #include <stdlib.h>  // NOLINT
@@ skipping 29 matching lines @@
   // Nothing to do on Android.
   return true;
 }
 
 
 intptr_t Socket::Create(RawAddr addr) {
   intptr_t fd;
 
   fd = TEMP_FAILURE_RETRY(socket(addr.ss.ss_family, SOCK_STREAM, 0));
   if (fd < 0) {
-    Log::PrintErr("Error Create: %s\n", strerror(errno));
+    const int kBufferSize = 1024;
+    char error_message[kBufferSize];
+    strerror_r(errno, error_message, kBufferSize);
+    Log::PrintErr("Error Create: %s\n", error_message);
     return -1;
   }
 
   FDUtils::SetCloseOnExec(fd);
   return fd;
 }
 
 
 intptr_t Socket::Connect(intptr_t fd, RawAddr addr, const intptr_t port) {
   SocketAddress::SetAddrPort(&addr, port);
@@ skipping 53 matching lines @@
 
 
 intptr_t Socket::GetPort(intptr_t fd) {
   ASSERT(fd >= 0);
   RawAddr raw;
   socklen_t size = sizeof(raw);
   if (TEMP_FAILURE_RETRY(
           getsockname(fd,
                       &raw.addr,
                       &size))) {
-    Log::PrintErr("Error getsockname: %s\n", strerror(errno));
+    const int kBufferSize = 1024;
+    char error_message[kBufferSize];
+    strerror_r(errno, error_message, kBufferSize);
+    Log::PrintErr("Error getsockname: %s\n", error_message);
     return 0;
   }
   return SocketAddress::GetAddrPort(&raw);
 }
 
 
 bool Socket::GetRemotePeer(intptr_t fd, char *host, intptr_t *port) {
   ASSERT(fd >= 0);
   RawAddr raw;
   socklen_t size = sizeof(raw);
   if (TEMP_FAILURE_RETRY(
           getpeername(fd,
                       &raw.addr,
                       &size))) {
-    Log::PrintErr("Error getpeername: %s\n", strerror(errno));
+    const int kBufferSize = 1024;
+    char error_message[kBufferSize];
+    strerror_r(errno, error_message, kBufferSize);
+    Log::PrintErr("Error getpeername: %s\n", error_message);
     return false;
   }
   const void* src;
   if (raw.ss.ss_family == AF_INET6) {
     src = reinterpret_cast<const void*>(&raw.in6.sin6_addr);
   } else {
     src = reinterpret_cast<const void*>(&raw.in.sin_addr);
   }
   if (inet_ntop(raw.ss.ss_family,
                 src,
                 host,
                 INET_ADDRSTRLEN) == NULL) {
-    Log::PrintErr("Error inet_ntop: %s\n", strerror(errno));
+    const int kBufferSize = 1024;
+    char error_message[kBufferSize];
+    strerror_r(errno, error_message, kBufferSize);
+    Log::PrintErr("Error inet_ntop: %s\n", error_message);
     return false;
   }
   *port = SocketAddress::GetAddrPort(&raw);
   return true;
 }
 
 
 void Socket::GetError(intptr_t fd, OSError* os_error) {
   int errorNumber;
   socklen_t len = sizeof(errorNumber);
@@ skipping 200 matching lines @@
                                        IPPROTO_TCP,
                                        TCP_NODELAY,
                                        reinterpret_cast<char *>(&on),
                                        sizeof(on))) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)