Fix bug with optimized try-catch on ARM/MIPS.

Fix bug with optimized try-catch on ARM/MIPS.

The constant pool pointer must be restored before any parallel
moves at the catch-entry block.

In addition, this CL removes CatchEntryInstr and folds its
functionality into CatchBlockEntryInstr. Until now every catch-block
started with CatchBlockEntryInstr followed by a CatchEntryInstr.

This simplifies a lot of code in the compiler and avoids issues
with allocator-move code inserted between the two instructions.

BUG=https://code.google.com/p/dart/issues/detail?id=12291
TEST=tests/language/try_catch4_test.dart
R=regis@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25918

[Florian Schneider, 2013-08-07 15:13:50]

This a bug fix plus a simplifying refactoring. Patch set #1 just contains the
bug fix for reference affecting ARM/MIPS.

[regis, 2013-08-07 17:04:47]

LGTM

Thanks for fixing this!

[srdjan, 2013-08-07 18:46:17]

lgtm

https://codereview.chromium.org/22590002/diff/7001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/22590002/diff/7001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:3345: intptr_t catch_handler_index =
(finally_block == NULL)
const

[Florian Schneider, 2013-08-08 07:39:57]

https://codereview.chromium.org/22590002/diff/7001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/22590002/diff/7001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:3345: intptr_t catch_handler_index =
(finally_block == NULL)
On 2013/08/07 18:46:17, srdjan wrote:
> const

Done.

[Florian Schneider, 2013-08-08 08:20:20]

Committed patchset #2 manually as r25918 (presubmit successful).