Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 22590002: Fix bug with optimized try-catch on ARM/MIPS. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: added cleanup of CatchEntry Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 772 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 const intptr_t num_non_copied_params = flow_graph().num_non_copied_params(); 783 const intptr_t num_non_copied_params = flow_graph().num_non_copied_params();
784 const intptr_t param_base = 784 const intptr_t param_base =
785 kParamEndSlotFromFp + num_non_copied_params; 785 kParamEndSlotFromFp + num_non_copied_params;
786 for (; i < num_non_copied_params; ++i) { 786 for (; i < num_non_copied_params; ++i) {
787 if ((*idefs)[i]->IsConstant()) continue; // Common constants 787 if ((*idefs)[i]->IsConstant()) continue; // Common constants
788 Location loc = env->LocationAt(i); 788 Location loc = env->LocationAt(i);
789 EmitTrySyncMove((param_base - i) * kWordSize, loc, &push_emitted); 789 EmitTrySyncMove((param_base - i) * kWordSize, loc, &push_emitted);
790 } 790 }
791 791
792 // Process locals. Skip exception_var and stacktrace_var. 792 // Process locals. Skip exception_var and stacktrace_var.
793 CatchEntryInstr* catch_entry = catch_block->next()->AsCatchEntry();
794 intptr_t local_base = kFirstLocalSlotFromFp + num_non_copied_params; 793 intptr_t local_base = kFirstLocalSlotFromFp + num_non_copied_params;
795 intptr_t ex_idx = local_base - catch_entry->exception_var().index(); 794 intptr_t ex_idx = local_base - catch_block->exception_var().index();
796 intptr_t st_idx = local_base - catch_entry->stacktrace_var().index(); 795 intptr_t st_idx = local_base - catch_block->stacktrace_var().index();
797 for (; i < flow_graph().variable_count(); ++i) { 796 for (; i < flow_graph().variable_count(); ++i) {
798 if (i == ex_idx || i == st_idx) continue; 797 if (i == ex_idx || i == st_idx) continue;
799 if ((*idefs)[i]->IsConstant()) continue; 798 if ((*idefs)[i]->IsConstant()) continue;
800 Location loc = env->LocationAt(i); 799 Location loc = env->LocationAt(i);
801 EmitTrySyncMove((local_base - i) * kWordSize, loc, &push_emitted); 800 EmitTrySyncMove((local_base - i) * kWordSize, loc, &push_emitted);
802 // Update safepoint bitmap to indicate that the target location 801 // Update safepoint bitmap to indicate that the target location
803 // now contains a pointer. 802 // now contains a pointer.
804 instr->locs()->stack_bitmap()->Set(i - num_non_copied_params, true); 803 instr->locs()->stack_bitmap()->Set(i - num_non_copied_params, true);
805 } 804 }
806 if (push_emitted) { 805 if (push_emitted) {
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1901 DRegister dreg = EvenDRegisterOf(reg); 1900 DRegister dreg = EvenDRegisterOf(reg);
1902 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1901 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1903 } 1902 }
1904 1903
1905 1904
1906 #undef __ 1905 #undef __
1907 1906
1908 } // namespace dart 1907 } // namespace dart
1909 1908
1910 #endif // defined TARGET_ARCH_ARM 1909 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698