test.dart: Shorten long paths for generated test files on Windows.

test.dart: Shorten long paths for generated test files on Windows.

BUG=
R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34778

[kustermann, 2014-04-07 09:02:23]

https://codereview.chromium.org/225863004/diff/1/tools/testing/dart/test_suit...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/225863004/diff/1/tools/testing/dart/test_suit...
tools/testing/dart/test_suite.dart:317: }
Just call the function always. I'd encapsulate all of this in the function. I.e.

String testUniqueName = TestUtils.getPersistentShortPath(
    relative.ToString().replaceAll('/', '_'));

So you can do whatever magic in that function you want to do.

[Bill Hesse, 2014-04-07 13:56:26]

PTAL.

[kustermann, 2014-04-07 14:04:12]

LGTM

https://codereview.chromium.org/225863004/diff/10002/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/225863004/diff/10002/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:2139:
"pkg_polymer_example_canonicalization_test_canonicalization": "polycanon"
Would we hit the limit if you prefixed it with co19_short (or something like
that)?

[would make it obvious where it's coming from]

https://codereview.chromium.org/225863004/diff/10002/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:2146: path = 'gen/${path.substring(index)}';
Why not multitest as before?
[would make it obvious, we "gen"erate a lot of things :) ]

[Bill Hesse, 2014-04-07 14:47:11]

https://codereview.chromium.org/225863004/diff/10002/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/225863004/diff/10002/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:2139:
"pkg_polymer_example_canonicalization_test_canonicalization": "polycanon"
On 2014/04/07 14:04:12, kustermann wrote:
> Would we hit the limit if you prefixed it with co19_short (or something like
> that)?
> 
> [would make it obvious where it's coming from]

Done.

https://codereview.chromium.org/225863004/diff/10002/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:2146: path = 'gen/${path.substring(index)}';
On 2014/04/07 14:04:12, kustermann wrote:
> Why not multitest as before?
> [would make it obvious, we "gen"erate a lot of things :) ]

Done.

[Bill Hesse, 2014-04-07 14:47:37]

Committed patchset #3 manually as r34778 (presubmit successful).