test.dart: Shorten long paths for generated test files on Windows.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 283 matching lines @@
       return;
     }
 
     doTest(testCase);
   }
 
   String createGeneratedTestDirectoryHelper(
       String name, String dirname, Path testPath, String optionsName) {
     Path relative = testPath.relativeTo(TestUtils.dartDir());
     relative = relative.directoryPath.append(relative.filenameWithoutExtension);
-    String testUniqueName = relative.toString().replaceAll('/', '_');
+    String testPathString = relative.toString();
+    if (testPathString.startsWith('$buildDir/generated_tests')) {
+      testPathString =
+          testPathString.replaceFirst('$buildDir/generated_tests', 'multitest');
+    }
+    String testUniqueName = testPathString.replaceAll('/', '_');
     if (!optionsName.isEmpty) {
       testUniqueName = '$testUniqueName-$optionsName';
     }
+    final int WINDOWS_SHORTEN_PATH_LIMIT = 70;
+    if (Platform.operatingSystem == 'windows' &&
+        testUniqueName.length > WINDOWS_SHORTEN_PATH_LIMIT) {
+      testUniqueName = TestUtils.getPersistentWindowsShortPath(testUniqueName);
+    }

[kustermann, 2014/04/07 09:02:23]

Just call the function always. I'd encapsulate all of this in the function. I.e.

String testUniqueName = TestUtils.getPersistentShortPath(
    relative.ToString().replaceAll('/', '_'));

So you can do whatever magic in that function you want to do.

 
     Path generatedTestPath = new Path(buildDir)
         .append('generated_$name')
         .append(dirname)
         .append(testUniqueName);
 
     TestUtils.mkdirRecursive(new Path('.'), generatedTestPath);
     return new File(generatedTestPath.toNativePath()).absolute.path
         .replaceAll('\\', '/');
   }
@@ skipping 1030 matching lines @@
     String packageRoot = packageRootArgument(optionsFromFile['packageRoot']);
     if (packageRoot != null) args.add(packageRoot);
     args..add('package:polymer/deploy.dart')
         ..add('--test')..add(inputFile)
         ..add('--out')..add(outputDir);
 
     return CommandBuilder.instance.getProcessCommand(
         'polymer_deploy', dartVmBinaryFileName, args, environmentOverrides);
   }
 
-  String createGeneratedTestDirectoryHelper(
-      String name, String dirname, Path testPath, String optionsName) {
-    Path relative = testPath.relativeTo(TestUtils.dartDir());
-    relative = relative.directoryPath.append(relative.filenameWithoutExtension);
-    String testUniqueName = relative.toString().replaceAll('/', '_');
-    if (!optionsName.isEmpty) {
-      testUniqueName = '$testUniqueName-$optionsName';
-    }
-
-    Path generatedTestPath = new Path(buildDir)
-        .append('generated_$name')
-        .append(dirname)
-        .append(testUniqueName);
-
-    TestUtils.mkdirRecursive(new Path('.'), generatedTestPath);
-    return new File(generatedTestPath.toNativePath()).absolute.path
-        .replaceAll('\\', '/');
-  }
-
   String get scriptType {
     switch (configuration['compiler']) {
       case 'none':
       case 'dart2dart':
         return 'application/dart';
       case 'dart2js':
       case 'dartanalyzer':
       case 'dart2analyzer':
         return 'text/javascript';
       default:
@@ skipping 740 matching lines @@
    * Gets extra vm options passed to the testing script.
    */
   static List<String> getExtraVmOptions(Map configuration) {
     var extraVmOptions = [];
     if (configuration['vm_options'] != null) {
       extraVmOptions = configuration['vm_options'].split(" ");
       extraVmOptions.removeWhere((s) => s.trim() == "");
     }
     return extraVmOptions;
   }
+
+  static String getPersistentWindowsShortPath(String path) {
+    final replacements = const {
+      "tests_co19_src_WebPlatformTest1_shadow-dom_shadow-trees_":
+          "shadow-trees_",
+      "tests_co19_src_WebPlatformTest1_shadow-dom_elements-and-dom-objects_":
+          "shadowdom_",
+      "tests_co19_src_WebPlatformTest1_html-templates_parsing-html-templates_additions-to-":
+          "htmltemplates_add_",
+      "tests_co19_src_WebPlatformTest1_html-templates_parsing-html-templates_appending-to-a-template_":
+          "htmltemplates_append_",
+      "tests_co19_src_WebPlatformTest1_html-templates_parsing-html-templates_clearing-the-stack-back-to-a-given-context_":
+          "htmltemplates_clearstack_",
+      "tests_co19_src_WebPlatformTest1_html-templates_parsing-html-templates_creating-an-element-for-the-token_":
+          "htmltemplates_create_",
+      "tests_co19_src_WebPlatformTest1_html-templates_additions-to-the-steps-to-clone-a-node_":
+          "htmltemplates_clone_",
+      "tests_co19_src_LayoutTests_fast_dom_Document_CaretRangeFromPoint_caretRangeFromPoint-":
+          "caretrangefrompoint_"
+    };
+
+    for (var key in replacements.keys) {
+      if (path.startsWith(key)) {
+        return path.replaceFirst(key, replacements[key]);
+      }
+    }
+    return path;
+  }
 }
 
 class SummaryReport {
   static int total = 0;
   static int skipped = 0;
   static int skippedByDesign = 0;
   static int noCrash = 0;
   static int pass = 0;
   static int failOk = 0;
   static int fail = 0;
@@ skipping 49 matching lines @@
  * $skipped tests will be skipped ($skippedByDesign skipped by design)
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
-   }
+  }
 }