Issue 22580005: Implement IsNullCheck for CheckClassInstr. If input is nullable expected type, then check for null …

Issue 22580005: Implement IsNullCheck for CheckClassInstr. If input is nullable expected type, then check for null … (Closed)

Created:
7 years, 4 months ago by srdjan

Modified:
7 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), Cutch

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement IsNullCheck for CheckClassInstr. If input is nullable expected type, then check for null only. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25907

Patch Set 3 : #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -17 lines)			Patch
M	runtime/vm/il_printer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		2 chunks	+2 lines, -2 lines	2 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/vm/object_test.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #3 manually as r25907 (presubmit successful).

7 years, 4 months ago (2013-08-07 23:02:15 UTC) #3

Vyacheslav Egorov (Google)

drive by question https://codereview.chromium.org/22580005/diff/17001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/22580005/diff/17001/runtime/vm/intermediate_language_ia32.cc#newcode4069 runtime/vm/intermediate_language_ia32.cc:4069: __ cmpl(locs()->in(0).reg(), raw_null); Did you try ...

7 years, 4 months ago (2013-08-08 13:01:05 UTC) #4

srdjan

7 years, 4 months ago (2013-08-08 14:15:40 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/22580005/diff/17001/runtime/vm/intermediate_l...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/22580005/diff/17001/runtime/vm/intermediate_l...
runtime/vm/intermediate_language_ia32.cc:4069: __ cmpl(locs()->in(0).reg(),
raw_null);
On 2013/08/08 13:01:06, Vyacheslav Egorov (Google) wrote:
> Did you try to emit a testl() for nullable smis instead of comparison with
null?
> (shorter code)

We never emit CheckClassInstr for nullable Smi-s (using CheckSmi instead). Had
an assert, but it seems to have been lost. I will add it.

Expand Messages | Collapse Messages