runtime/vm/intermediate_language_arm.cc - Issue 22580005: Implement IsNullCheck for CheckClassInstr. If input is nullable expected type, then check for null …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 22580005: Implement IsNullCheck for CheckClassInstr. If input is nullable expected type, then check for null … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

===================================================================

--- runtime/vm/intermediate_language_arm.cc (revision 25902)

+++ runtime/vm/intermediate_language_arm.cc (working copy)

@@ -4008,7 +4008,7 @@

LocationSummary* summary =

new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);

summary->set_in(0, Location::RequiresRegister());

- if (!null_check()) {

+ if (!IsNullCheck()) {

summary->AddTemp(Location::RequiresRegister());

}

return summary;

@@ -4016,7 +4016,7 @@

void CheckClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

- if (null_check()) {

+ if (IsNullCheck()) {

Label* deopt = compiler->AddDeoptStub(deopt_id(),

kDeoptCheckClass);

__ CompareImmediate(locs()->in(0).reg(),

« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')