Fix for 15979- class aliases now have missing concrete members warnings generated on them.

Fix for 15979- class aliases now have missing concrete members warnings generated on them.

This CL also changes the ErrorVerifier.visitClassTypeAlias() method to more closely resemble ErrorVerifier.visitClassDeclaration(), a change is made to tests/lib/mirrors/abstract_class_test.dart, and a bug issue is fixed in TestTypeProvider.

Is there a better way to indicate that there is a warning on a line in a test file?

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34802

[scheglov, 2014-04-07 22:07:12]

analyzer changes lgtm

[rmacnak, 2014-04-07 22:24:18]

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
File tests/language/mixin_bound_test.dart (right):

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:104: class Expression =  /// 00: static
type warning
Should be declared abstract.

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:107: class Addition = /// 00: ok
We don't expect warnings here.

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:111: class Subtraction = /// 00: ok
We don't expect warnings here.

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:115: class Number = /// 00: ok
We don't expect warnings here.

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:120: class Multiplication = /// 00: ok
We don't expect warnings here.

[jwren, 2014-04-07 22:34:41]

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
File tests/language/mixin_bound_test.dart (right):

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:104: class Expression =  /// 00: static
type warning
On 2014/04/07 22:24:18, Ryan Macnak wrote:
> Should be declared abstract.

Got it, marking the alias as abstract the warning (and hence all the /// 00:...)
go away.

https://codereview.chromium.org/224963016/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:107: class Addition = /// 00: ok
Correct.  The special comment indicates that for the subtest ''00'', this line
should be included, and has no warnings: "ok".  Without these, there is a
reference to "Expression" without the declaration.

https://codereview.chromium.org/224963016/diff/1/tests/lib/mirrors/abstract_c...
File tests/lib/mirrors/abstract_class_test.dart (right):

https://codereview.chromium.org/224963016/diff/1/tests/lib/mirrors/abstract_c...
tests/lib/mirrors/abstract_class_test.dart:133: class ConcreteNamedMA = S with
M; /// 00: static type warning
Do you want this to be marked as abstract too?

[rmacnak, 2014-04-07 22:39:51]

https://codereview.chromium.org/224963016/diff/1/tests/lib/mirrors/abstract_c...
File tests/lib/mirrors/abstract_class_test.dart (right):

https://codereview.chromium.org/224963016/diff/1/tests/lib/mirrors/abstract_c...
tests/lib/mirrors/abstract_class_test.dart:133: class ConcreteNamedMA = S with
M; /// 00: static type warning
On 2014/04/07 22:34:41, jwren wrote:
> Do you want this to be marked as abstract too?

No, here we want to test the mirror system says this is not abstract even if it
doesn't fully implement the interface.

[jwren, 2014-04-07 23:30:14]

Committed patchset #2 manually as r34802 (presubmit successful).

[Brian Wilkerson, 2014-04-08 04:38:06]

LGTM