Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java

Issue 224963016: Fix for 15979- class aliases now have missing concrete members warnings generated on them. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
index 594ae2a16a258285731d77b0a2a15aa344c444d5..d85a0524abebc088c5eff3d88ea8c0ad6bc8b72c 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
@@ -2033,6 +2033,49 @@ public class StaticWarningCodeTest extends ResolverTestCase {
verify(source);
}
+ public void test_nonAbstractClassInheritsAbstractMemberOne_classTypeAlias_interface()
+ throws Exception {
+ // 15979
+ Source source = addSource(createSource(//
+ "abstract class M {}",
+ "abstract class A {}",
+ "abstract class I {",
+ " m();",
+ "}",
+ "class B = A with M implements I;"));
+ resolve(source);
+ assertErrors(source, StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
+ verify(source);
+ }
+
+ public void test_nonAbstractClassInheritsAbstractMemberOne_classTypeAlias_mixin()
+ throws Exception {
+ // 15979
+ Source source = addSource(createSource(//
+ "abstract class M {",
+ " m();",
+ "}",
+ "abstract class A {}",
+ "class B = A with M;"));
+ resolve(source);
+ assertErrors(source, StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
+ verify(source);
+ }
+
+ public void test_nonAbstractClassInheritsAbstractMemberOne_classTypeAlias_superclass()
+ throws Exception {
+ // 15979
+ Source source = addSource(createSource(//
+ "class M {}",
+ "abstract class A {",
+ " m();",
+ "}",
+ "class B = A with M;"));
+ resolve(source);
+ assertErrors(source, StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
+ verify(source);
+ }
+
public void test_nonAbstractClassInheritsAbstractMemberOne_ensureCorrectFunctionSubtypeIsUsedInImplementation()
throws Exception {
// 15028

Powered by Google App Engine
This is Rietveld 408576698