Only run [Transformer.isPrimary] once for each asset/transformer pair.

Only run [Transformer.isPrimary] once for each asset/transformer pair.

BUG=16442
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34857

[Bob Nystrom, 2014-04-04 18:21:44]

Couple of nits but LGTM!

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
File pkg/barback/lib/src/transform_node.dart (right):

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:1: // Copyright (c) 2013, the Dart
project authors.  Please see the AUTHORS file
I really like the changes here. It's much easier for me to grok it.

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:212: // [LazyTransformer], we can get
some mileage out of doing a declarative
declarative -> declaration

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:445: /// The transform is running
[Transformer.apply], but since it started an
This is a bit of a garden path sentence. Maybe: "but an input changed after it
started, so it will..."

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:461: /// This will never transition to
another state.
Once it hits this state, it closes its output streams and eventually falls off
the graph completely, right? Document that.

[nweiz, 2014-04-07 19:43:02]

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
File pkg/barback/lib/src/transform_node.dart (right):

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:1: // Copyright (c) 2013, the Dart
project authors.  Please see the AUTHORS file
On 2014/04/04 18:21:45, Bob Nystrom wrote:
> I really like the changes here. It's much easier for me to grok it.

Removing functionality can certainly have that effect :).

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:212: // [LazyTransformer], we can get
some mileage out of doing a declarative
On 2014/04/04 18:21:45, Bob Nystrom wrote:
> declarative -> declaration

Done.

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:445: /// The transform is running
[Transformer.apply], but since it started an
On 2014/04/04 18:21:45, Bob Nystrom wrote:
> This is a bit of a garden path sentence. Maybe: "but an input changed after it
> started, so it will..."

Done.

https://codereview.chromium.org/224933002/diff/20001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transform_node.dart:461: /// This will never transition to
another state.
On 2014/04/04 18:21:45, Bob Nystrom wrote:
> Once it hits this state, it closes its output streams and eventually falls off
> the graph completely, right? Document that.

No, it still needs to exist as long as the input does to pass through its input
and be counted by the [PhaseForwarder].

[nweiz, 2014-04-08 23:59:29]

Committed patchset #3 manually as r34857 (presubmit successful).