Issue 224903010: Pass RpcException error data through if it's not a map.

Issue 224903010: Pass RpcException error data through if it's not a map. (Closed)

Created:
6 years, 8 months ago by Bob Nystrom

Modified:
6 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Pass RpcException error data through if it's not a map. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=34748

Patch Set 2 : Revise. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
A	pkg/json_rpc_2/CHANGELOG.md	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/json_rpc_2/lib/src/exception.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/json_rpc_2/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/json_rpc_2/test/server/parameters_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/json_rpc_2/test/server/server_test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	pkg/json_rpc_2/test/server/utils.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/224903010/diff/1/pkg/json_rpc_2/pubspec.yaml File pkg/json_rpc_2/pubspec.yaml (right): https://codereview.chromium.org/224903010/diff/1/pkg/json_rpc_2/pubspec.yaml#newcode2 pkg/json_rpc_2/pubspec.yaml:2: version: 0.0.3 This is a bug fix, so ...

6 years, 8 months ago (2014-04-04 22:03:57 UTC) #2

Bob Nystrom

https://codereview.chromium.org/224903010/diff/1/pkg/json_rpc_2/pubspec.yaml File pkg/json_rpc_2/pubspec.yaml (right): https://codereview.chromium.org/224903010/diff/1/pkg/json_rpc_2/pubspec.yaml#newcode2 pkg/json_rpc_2/pubspec.yaml:2: version: 0.0.3 On 2014/04/04 22:03:57, nweiz wrote: > This ...

6 years, 8 months ago (2014-04-04 22:09:13 UTC) #3

Bob Nystrom

6 years, 8 months ago (2014-04-04 22:09:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34748 (presubmit successful).

Expand Messages | Collapse Messages