Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: pkg/json_rpc_2/test/server/utils.dart

Issue 224903010: Pass RpcException error data through if it's not a map. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/json_rpc_2/test/server/server_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/json_rpc_2/test/server/utils.dart
diff --git a/pkg/json_rpc_2/test/server/utils.dart b/pkg/json_rpc_2/test/server/utils.dart
index 07f571ce6c295dda02cb63ce608b78d96d08df37..6f92c0a5456b46bb80fb4efb62c61d4c91935ac5 100644
--- a/pkg/json_rpc_2/test/server/utils.dart
+++ b/pkg/json_rpc_2/test/server/utils.dart
@@ -8,9 +8,10 @@ import 'package:unittest/unittest.dart';
import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
void expectErrorResponse(json_rpc.Server server, request, int errorCode,
- String message) {
+ String message, {data}) {
var id;
if (request is Map) id = request['id'];
+ if (data == null) data = {'request': request};
expect(server.handleRequest(request), completion(equals({
'jsonrpc': '2.0',
@@ -18,7 +19,7 @@ void expectErrorResponse(json_rpc.Server server, request, int errorCode,
'error': {
'code': errorCode,
'message': message,
- 'data': {'request': request}
+ 'data': data
}
})));
}
« no previous file with comments | « pkg/json_rpc_2/test/server/server_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698