Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2232533002: Rename nestingMiddleware to PathHandler.nestedIn. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M lib/src/runner/browser/platform.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/path_handler.dart View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 4 months ago (2016-08-09 20:07:43 UTC) #1
jakemac
lgtm https://codereview.chromium.org/2232533002/diff/1/lib/src/util/io.dart File lib/src/util/io.dart (right): https://codereview.chromium.org/2232533002/diff/1/lib/src/util/io.dart#newcode10 lib/src/util/io.dart:10: import 'package:shelf/shelf.dart' as shelf; Not sure why this ...
4 years, 4 months ago (2016-08-09 20:12:24 UTC) #2
nweiz
Code review changes
4 years, 4 months ago (2016-08-09 22:01:30 UTC) #3
nweiz
https://codereview.chromium.org/2232533002/diff/1/lib/src/util/io.dart File lib/src/util/io.dart (right): https://codereview.chromium.org/2232533002/diff/1/lib/src/util/io.dart#newcode10 lib/src/util/io.dart:10: import 'package:shelf/shelf.dart' as shelf; On 2016/08/09 20:12:24, jakemac wrote: ...
4 years, 4 months ago (2016-08-09 22:01:34 UTC) #4
nweiz
4 years, 4 months ago (2016-08-09 22:02:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d946756e7a0ed51646127426ea2620bc70ec21d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698