Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 222483003: Remove workarounds for 13002 in smoke and polymer (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove workaround for 13002 in smoke and in a polymer test, woohoo! R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34663

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M pkg/polymer/test/event_handlers_test.dart View 1 chunk +2 lines, -7 lines 1 comment Download
M pkg/smoke/lib/mirrors.dart View 2 chunks +1 line, -30 lines 0 comments Download
M pkg/smoke/pubspec.yaml View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/222483003/diff/20001/pkg/polymer/test/event_handlers_test.dart File pkg/polymer/test/event_handlers_test.dart (right): https://codereview.chromium.org/222483003/diff/20001/pkg/polymer/test/event_handlers_test.dart#newcode92 pkg/polymer/test/event_handlers_test.dart:92: @reflectable void itemTapAction(e, d, n) { technically now our ...
6 years, 8 months ago (2014-04-02 18:13:27 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/222483003/diff/20001/pkg/smoke/pubspec.yaml File pkg/smoke/pubspec.yaml (right): https://codereview.chromium.org/222483003/diff/20001/pkg/smoke/pubspec.yaml#newcode22 pkg/smoke/pubspec.yaml:22: sdk: ">=1.3.0-dev.7.9 <2.0.0" I think we had our ...
6 years, 8 months ago (2014-04-02 18:15:54 UTC) #2
Siggi Cherem (dart-lang)
On 2014/04/02 18:15:54, John Messerly wrote: > lgtm > > https://codereview.chromium.org/222483003/diff/20001/pkg/smoke/pubspec.yaml > File pkg/smoke/pubspec.yaml (right): ...
6 years, 8 months ago (2014-04-02 18:20:47 UTC) #3
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-02 20:19:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r34663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698