Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: pkg/polymer/test/event_handlers_test.dart

Issue 222483003: Remove workarounds for 13002 in smoke and polymer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/smoke/lib/mirrors.dart » ('j') | pkg/smoke/pubspec.yaml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/event_handlers_test.dart
diff --git a/pkg/polymer/test/event_handlers_test.dart b/pkg/polymer/test/event_handlers_test.dart
index 852d44d4812089057711bdde006a14fbcd9318be..867266a79900cbd07f442e88f7647cb18d267def 100644
--- a/pkg/polymer/test/event_handlers_test.dart
+++ b/pkg/polymer/test/event_handlers_test.dart
@@ -89,16 +89,11 @@ class XTest extends PolymerElement {
class MiniModel extends Observable {
XTest _element;
@observable final int index;
- @reflectable Function itemTapAction;
- _itemTapAction(e, d, n) {
+ @reflectable void itemTapAction(e, d, n) {
Siggi Cherem (dart-lang) 2014/04/02 18:13:27 technically now our build process uses codegen and
_element._logEvent(e, 'mini-model callback $this');
e.stopPropagation();
}
- MiniModel(this._element, this.index) {
- // TODO(sigmund): remove this and reflect directly on the method. This is
- // needed to work around bug 13002
- itemTapAction = _itemTapAction;
- }
+ MiniModel(this._element, this.index);
String toString() => "<mini-model $index>";
}
« no previous file with comments | « no previous file | pkg/smoke/lib/mirrors.dart » ('j') | pkg/smoke/pubspec.yaml » ('J')

Powered by Google App Engine
This is Rietveld 408576698