Issue 22174002: Do not rely on the exit code of browser to determine if the *command* was successful

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22174002: Do not rely on the exit code of browser to determine if the command was successful (Closed)

Created:
7 years, 4 months ago by kustermann

Modified:
7 years, 4 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not rely on the exit code of browser to determine if the *command* was successful R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=25764

Patch Set 2 : #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

https://codereview.chromium.org/22174002/diff/2001/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/22174002/diff/2001/tools/testing/dart/test_runner.dart#newcode732 tools/testing/dart/test_runner.dart:732: return super.canRunDependendCommands && !didFail(null); If this returns 'false' and ...

7 years, 4 months ago (2013-08-05 10:23:44 UTC) #1

kustermann

7 years, 4 months ago (2013-08-05 10:30:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25764 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22174002: Do not rely on the exit code of browser to determine if the *command* was successful (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages

Issue 22174002: Do not rely on the exit code of browser to determine if the command was successful (Closed)