Properly handle web socket requests to half-initialized servers.

Properly handle web socket requests to half-initialized servers.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34629

[Bob Nystrom, 2014-04-02 00:50:17]

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart:37:
expect(results[1], contains("result"));
Why isn't this an error?

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart:38:
expect(results[0]["result"], equals(results[1]["result"]));
This isn't clear to me. These two methods should have the same result? What
should that be? Can you test for it explicitly?

[nweiz, 2014-04-02 00:58:55]

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart:37:
expect(results[1], contains("result"));
On 2014/04/02 00:50:17, Bob Nystrom wrote:
> Why isn't this an error?

You designed the API to return the existing server URL if a directory was
already being served.

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart:38:
expect(results[0]["result"], equals(results[1]["result"]));
On 2014/04/02 00:50:17, Bob Nystrom wrote:
> This isn't clear to me. These two methods should have the same result? What
> should that be? Can you test for it explicitly?

We can't really test explicitly, because the URL is going to have a
dynamically-assigned port. I'll add some more documentation, though.

[Bob Nystrom, 2014-04-02 01:00:27]

lgtm

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart:37:
expect(results[1], contains("result"));
On 2014/04/02 00:58:55, nweiz wrote:
> On 2014/04/02 00:50:17, Bob Nystrom wrote:
> > Why isn't this an error?
> 
> You designed the API to return the existing server URL if a directory was
> already being served.

Heh, oh, right.

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart:38:
expect(results[0]["result"], equals(results[1]["result"]));
On 2014/04/02 00:58:55, nweiz wrote:
> On 2014/04/02 00:50:17, Bob Nystrom wrote:
> > This isn't clear to me. These two methods should have the same result? What
> > should that be? Can you test for it explicitly?
> 
> We can't really test explicitly, because the URL is going to have a
> dynamically-assigned port. I'll add some more documentation, though.

Yeah, a bit of docs, and a test that the result is a URL would be enough.

[nweiz, 2014-04-02 01:04:20]

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart
(right):

https://codereview.chromium.org/221173007/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart:38:
expect(results[0]["result"], equals(results[1]["result"]));
On 2014/04/02 01:00:28, Bob Nystrom wrote:
> On 2014/04/02 00:58:55, nweiz wrote:
> > On 2014/04/02 00:50:17, Bob Nystrom wrote:
> > > This isn't clear to me. These two methods should have the same result?
What
> > > should that be? Can you test for it explicitly?
> > 
> > We can't really test explicitly, because the URL is going to have a
> > dynamically-assigned port. I'll add some more documentation, though.
> 
> Yeah, a bit of docs, and a test that the result is a URL would be enough.

Done.

[nweiz, 2014-04-02 01:04:59]

Committed patchset #2 manually as r34629 (presubmit successful).