Issue 219993004: Fix line number table generation for multiline strings with interpolation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219993004: Fix line number table generation for multiline strings with interpolation. (Closed)

Created:
6 years, 8 months ago by turnidge

Modified:
6 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix line number table generation for multiline strings with interpolation. Share the line number table generation code between debugger and vm service. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=34606

Patch Set 1 #

Total comments: 2

Patch Set 2 : post code review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -69 lines)			Patch
M	runtime/vm/debugger_api_impl.cc	View		1 chunk	+1 line, -34 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+92 lines, -35 lines	0 comments	Download
M	runtime/vm/scanner.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://codereview.chromium.org/219993004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/219993004/diff/1/runtime/vm/object.cc#newcode7610 runtime/vm/object.cc:7610: // 13 string('') interpol_var(foo) interpol_var is followed at ...

6 years, 8 months ago (2014-03-31 23:11:32 UTC) #2

turnidge

https://codereview.chromium.org/219993004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/219993004/diff/1/runtime/vm/object.cc#newcode7610 runtime/vm/object.cc:7610: // 13 string('') interpol_var(foo) On 2014/03/31 23:11:32, hausner wrote: ...

6 years, 8 months ago (2014-04-01 18:06:05 UTC) #3

turnidge

6 years, 8 months ago (2014-04-01 18:16:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34606 (presubmit successful).

Expand Messages | Collapse Messages