runtime/vm/scanner.cc - Issue 219993004: Fix line number table generation for multiline strings with interpolation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scanner.cc

Issue 219993004: Fix line number table generation for multiline strings with interpolation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: post code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scanner.cc

diff --git a/runtime/vm/scanner.cc b/runtime/vm/scanner.cc

index 7e1dfbe6a4910735a0dd7722612601e513fb3424..761c0c1670bee1c4e99f0137ddc964e8cb432ec3 100644

--- a/runtime/vm/scanner.cc

+++ b/runtime/vm/scanner.cc

@@ -874,6 +874,8 @@ void Scanner::ScanAll(GrowableTokenStream* token_stream) {

if (inserted_new_lines &&

((current_token_.kind == Token::kINTERPOL_VAR) ||

(current_token_.kind == Token::kINTERPOL_START))) {

+ // NOTE: If this changes, be sure to update

+ // Script::GenerateLineNumberArray to stay in sync.

empty_string_token_.position.line = current_token_.position.line;

token_stream->Add(empty_string_token_);

}

« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »