Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 21999002: Fixed [:foo:]-style markdown links and added lookup within the library (Closed)

Created:
7 years, 4 months ago by Tate Mandel
Modified:
7 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, janicejl
Visibility:
Public.

Description

Fixed [:foo:]-style markdown links and added lookup within the library R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=25755

Patch Set 1 #

Patch Set 2 : Changed [:...:] style markdown to <code> and not <a> #

Total comments: 4

Patch Set 3 : Fixed comment and if statements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M pkg/docgen/lib/docgen.dart View 1 2 4 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tate Mandel
I also fixed a bug where checking for mixins would throw an exception if the ...
7 years, 4 months ago (2013-08-02 22:38:15 UTC) #1
Emily Fortuna
https://codereview.chromium.org/21999002/diff/4001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/21999002/diff/4001/pkg/docgen/lib/docgen.dart#newcode50 pkg/docgen/lib/docgen.dart:50: /// Add support for [:foo:]-style code to the markdown ...
7 years, 4 months ago (2013-08-02 23:26:55 UTC) #2
Tate Mandel
https://codereview.chromium.org/21999002/diff/4001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/21999002/diff/4001/pkg/docgen/lib/docgen.dart#newcode50 pkg/docgen/lib/docgen.dart:50: /// Add support for [:foo:]-style code to the markdown ...
7 years, 4 months ago (2013-08-02 23:54:35 UTC) #3
Emily Fortuna
lgtm
7 years, 4 months ago (2013-08-03 00:05:38 UTC) #4
Tate Mandel
7 years, 4 months ago (2013-08-03 00:06:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r25755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698