Fixed [:foo:]-style markdown links and added lookup within the library

pkg/docgen/lib/docgen.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * **docgen** is a tool for creating machine readable representations of Dart
  * code metadata, including: classes, members, comments and annotations.
  *
  * docgen is run on a `.dart` file or a directory containing `.dart` files.
  *
@@ skipping 29 matching lines @@
 
 /// Current library being documented to be used for comment links.
 LibraryMirror _currentLibrary;
 
 /// Current class being documented to be used for comment links.
 ClassMirror _currentClass;
 
 /// Current member being documented to be used for comment links.
 MemberMirror _currentMember;
 
+/// Add support for [:foo:]-style code to the markdown parser.

[Emily Fortuna, 2013/08/02 23:26:55]

nit: can we make this comment slightly clearer: support for [:foo:]-style code
comments...

[Tate Mandel, 2013/08/02 23:54:36]

Done.

+List<markdown.InlineSyntax> markdownSyntaxes = 
+  [new markdown.CodeSyntax(r'\[:\s?((?:.|\n)*?)\s?:\]')];
+ 
 /// Resolves reference links in doc comments.
 markdown.Resolver linkResolver;
 
 /// Index of all indexable items. This also ensures that no class is 
 /// created more than once. 
 Map<String, Indexable> entityMap = new Map<String, Indexable>();
 
 /// This is set from the command line arguments flag --include-private 
 bool _includePrivate = false;
 
@@ skipping 256 matching lines @@
         if (commentText == null) {
           commentText = comment.trimmedText;
         } else {
           commentText = '$commentText ${comment.trimmedText}';
         }
       }
     }
   });
   
   commentText = commentText == null ? '' : 
-      markdown.markdownToHtml(commentText.trim(), linkResolver: linkResolver);
+      markdown.markdownToHtml(commentText.trim(), linkResolver: linkResolver,
+          inlineSyntaxes: markdownSyntaxes);
   return commentText;
 }
 
 /**
  * Converts all [foo] references in comments to <a>libraryName.foo</a>.
  */
 markdown.Node fixReference(String name, LibraryMirror currentLibrary,
     ClassMirror currentClass, MemberMirror currentMember) {
   var reference;
   var memberScope = currentMember == null ?
       null : currentMember.lookupInScope(name);
   if (memberScope != null) reference = memberScope.qualifiedName;
   else {
     var classScope = currentClass == null ?
         null : currentClass.lookupInScope(name);
-    reference = classScope != null ? classScope.qualifiedName : name;
+    if (classScope != null) reference = classScope.qualifiedName;

[Emily Fortuna, 2013/08/02 23:26:55]

if you have an else branch, go ahead and put the if branch also on a separate
line:
if (classScope...) {
  reference = ...;
} else  {
 ...
}

[Tate Mandel, 2013/08/02 23:54:36]

Done.

+    else {
+      var libraryScope = currentLibrary == null ?
+          null : currentLibrary.lookupInScope(name);
+      reference = libraryScope != null ? libraryScope.qualifiedName : name;
+    }
   }
   return new markdown.Element.text('a', reference);
 }
 
 /**
  * Returns a map of [Variable] objects constructed from [mirrorMap].
  */
 Map<String, Variable> _variables(Map<String, VariableMirror> mirrorMap) {
   var data = {};
   // TODO(janicejl): When map to map feature is created, replace the below with
@@ skipping 260 matching lines @@
   }
   
   /**
    * Check that the class exists in the owner library.
    *  
    * If it does not exist in the owner library, it is a mixin applciation and 
    * should be removed. 
    */
   void makeValid() {
     var library = entityMap[owner];
-    if (!library.classes.containsKey(name)) {
+    if (library != null && !library.classes.containsKey(name)) {
       this.isPrivate = true;
       // Since we are now making the mixin a private class, make all elements 
       // with the mixin as an owner private too. 
       entityMap.values.where((e) => e.owner == qualifiedName)
         .forEach((element) => element.isPrivate = true);
       // Move the subclass up to the next public superclass
       subclasses.forEach((subclass) => addSubclass(entityMap[subclass]));
     }
   }
   
@@ skipping 373 matching lines @@
   String qualifiedName;
   List<String> parameters; 
   
   Annotation(this.qualifiedName, this.parameters);
   
   Map toMap() => {
     'name': qualifiedName,
     'parameters': parameters
   };
 }