Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 219113002: Extract create_sdk build rule to own file to avoid cycle. (Closed)

Created:
6 years, 8 months ago by ahe
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, ricow1, Bill Hesse, dgrove, kasperl
Visibility:
Public.

Description

Extract create_sdk build rule to own file to avoid cycle. Also, build Try Dart on dart2js build bots. R=kustermann@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34550

Patch Set 1 #

Total comments: 2

Patch Set 2 : Break long lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -51 lines) Patch
A dart/create_sdk.gyp View 1 chunk +48 lines, -0 lines 0 comments Download
M dart/dart.gyp View 1 9 chunks +10 lines, -49 lines 0 comments Download
M dart/site/try/build_try.gyp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
6 years, 8 months ago (2014-03-31 09:48:18 UTC) #1
kustermann
LGTM
6 years, 8 months ago (2014-03-31 10:24:07 UTC) #2
ricow1
LGTM Filed https://code.google.com/p/dart/issues/detail?id=17913 to move the gyp file down https://codereview.chromium.org/219113002/diff/1/dart/dart.gyp File dart/dart.gyp (right): https://codereview.chromium.org/219113002/diff/1/dart/dart.gyp#newcode104 dart/dart.gyp:104: ...
6 years, 8 months ago (2014-03-31 10:39:57 UTC) #3
ahe
Committed patchset #2 manually as r34550 (presubmit successful).
6 years, 8 months ago (2014-03-31 11:00:08 UTC) #4
ahe
Thank you! https://codereview.chromium.org/219113002/diff/1/dart/dart.gyp File dart/dart.gyp (right): https://codereview.chromium.org/219113002/diff/1/dart/dart.gyp#newcode104 dart/dart.gyp:104: # This dependency on create_sdk.gyp:create_sdk does not ...
6 years, 8 months ago (2014-03-31 11:01:12 UTC) #5
Emily Fortuna
6 years, 8 months ago (2014-04-01 00:00:25 UTC) #6
Message was sent while issue was closed.
I'm running into some weird behavior trying to build "create_sdk" in my svn
checkouts, I'm guessing as a result of this change. I've seen this behavior on
multiple machines and checkouts.

Deleting the output directory and building clean does NOT fix the problem. 
"gclient sync" also does not fix the problem.

I was able to fix the problem by running "gclient runhooks" specifically, which
is curious because for svn checkouts, "runhooks" is supposed to be run as part
of "sync".

Here's the error:

PhaseScriptExecution Action\ \"create_sdk_py\"
xcodebuild/create_sdk.build/ReleaseIA32/create_sdk_internal.build/Script-3E87446A67856E9D1F8E65B9.sh
    cd /Users/efortuna/dart_checkout_for_perf_testing/dart
    /bin/sh -c
/Users/efortuna/dart_checkout_for_perf_testing/dart/xcodebuild/create_sdk.build/ReleaseIA32/create_sdk_internal.build/Script-3E87446A67856E9D1F8E65B9.sh
note: Creating SDK.
Traceback (most recent call last):
  File "tools/create_sdk.py", line 268, in <module>
    sys.exit(Main(sys.argv))
  File "tools/create_sdk.py", line 247, in Main
    CopySnapshots(SNAPSHOT, SDK_tmp)
  File "tools/create_sdk.py", line 120, in CopySnapshots
    join(sdk_root, 'bin', 'snapshots', snapshot))
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
line 82, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory:
'/Users/efortuna/dart_checkout_for_perf_testing/dart/xcodebuild/DerivedSources/ReleaseIA32/dartfmt.dart.snapshot'
Command /bin/sh failed with exit code 1

** BUILD FAILED **

The following build commands failed:
PhaseScriptExecution Action\ \"create_sdk_py\"
xcodebuild/create_sdk.build/ReleaseIA32/create_sdk_internal.build/Script-3E87446A67856E9D1F8E65B9.sh
(1 failure)
BUILD FAILED

Powered by Google App Engine
This is Rietveld 408576698