Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: dart/dart.gyp

Issue 219113002: Extract create_sdk build rule to own file to avoid cycle. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Break long lines. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/create_sdk.gyp ('k') | dart/site/try/build_try.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/dart.gyp
diff --git a/dart/dart.gyp b/dart/dart.gyp
index 6723ce4990b745f9410dea169acd66af44c4e893..17eea78834790b62049c052c582944f14e1fbb62 100644
--- a/dart/dart.gyp
+++ b/dart/dart.gyp
@@ -9,7 +9,7 @@
'type': 'none',
'dependencies': [
'analyzer',
- 'create_sdk',
+ 'create_sdk.gyp:create_sdk',
'dart2js',
'editor',
'packages',
@@ -34,46 +34,6 @@
],
},
{
- 'target_name': 'create_sdk',
- 'type': 'none',
- 'dependencies': [
- 'runtime/dart-runtime.gyp:dart',
- 'utils/compiler/compiler.gyp:dart2js',
- 'utils/pub/pub.gyp:pub',
- 'dartfmt',
- 'analyzer',
- ],
- 'actions': [
- {
- 'action_name': 'create_sdk_py',
- 'inputs': [
- '<!@(["python", "tools/list_files.py", "\\.dart$", "sdk/lib"])',
- '<!@(["python", "tools/list_files.py", "", '
- '"sdk/lib/_internal/lib/preambles"])',
- '<!@(["python", "tools/list_files.py", "", "sdk/bin"])',
- 'tools/create_sdk.py',
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)',
- '<(SHARED_INTERMEDIATE_DIR)/dart2js.dart.snapshot',
- '<(SHARED_INTERMEDIATE_DIR)/utils_wrapper.dart.snapshot',
- '<(SHARED_INTERMEDIATE_DIR)/pub.dart.snapshot',
- '<(PRODUCT_DIR)/dartanalyzer/dartanalyzer.jar',
- '<(SHARED_INTERMEDIATE_DIR)/dartfmt.dart.snapshot',
- 'tools/VERSION'
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/dart-sdk/README',
- ],
- 'action': [
- 'python',
- 'tools/create_sdk.py',
- '--sdk_output_dir', '<(PRODUCT_DIR)/dart-sdk',
- '--snapshot_location', '<(SHARED_INTERMEDIATE_DIR)/'
- ],
- 'message': 'Creating SDK.',
- },
- ],
- },
- {
'target_name': 'dart2js',
'type': 'none',
'dependencies': [
@@ -101,7 +61,7 @@
'target_name': 'dart2dart_bot',
'type': 'none',
'dependencies': [
- 'create_sdk',
+ 'create_sdk.gyp:create_sdk',
'packages',
],
},
@@ -112,7 +72,7 @@
'target_name': 'dartc_bot',
'type': 'none',
'dependencies': [
- 'create_sdk',
+ 'create_sdk.gyp:create_sdk',
'packages',
],
},
@@ -123,8 +83,9 @@
'target_name': 'dart2js_bot',
'type': 'none',
'dependencies': [
- 'create_sdk',
+ 'create_sdk.gyp:create_sdk',
'packages',
+ 'try',
],
},
{
@@ -140,8 +101,8 @@
'dependencies': [
'editor/build/generated/editor_deps.gyp:editor_deps',
- # This dependency on create_sdk does not mean that the Editor
- # is rebuilt if the SDK is. It only means that when you build
+ # This dependency on create_sdk.gyp:create_sdk does not mean that the
+ # Editor is rebuilt if the SDK is. It only means that when you build
# the Editor, you should also build the SDK. If we wanted to
# make sure that the editor is rebuilt when the SDK is, we
# should list a *file* in PRODUCT_DIR which the action below
@@ -149,7 +110,7 @@
# This is the desired behavior as we would otherwise have to
# rebuild the editor each time the VM, dart2js, or library
# code changes.
- 'create_sdk',
+ 'create_sdk.gyp:create_sdk',
],
'actions': [
{
@@ -157,7 +118,8 @@
'inputs': [
'tools/create_editor.py',
'<(SHARED_INTERMEDIATE_DIR)/editor_deps/editor.stamp',
- '<!@(["python", "tools/list_files.py", "", "editor/tools/features/com.google.dart.tools.deploy.feature_releng"])',
+ '<!@(["python", "tools/list_files.py", "", "editor/tools/features/'
+ 'com.google.dart.tools.deploy.feature_releng"])',
],
'outputs': [
'<(PRODUCT_DIR)/editor/VERSION',
@@ -196,7 +158,6 @@
'target_name': 'try',
'type': 'none',
'dependencies': [
- 'create_sdk',
'site/try/build_try.gyp:try_site',
],
},
« no previous file with comments | « dart/create_sdk.gyp ('k') | dart/site/try/build_try.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698