Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2187043003: Fix a crashing bug. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_map_stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a crashing bug. If a SyncPackageResolver is passed in without any package resolution strategy, this would throw a method not found exception. R=jmesserly@google.com Committed: https://github.com/dart-lang/source_map_stack_trace/commit/7d7c617052d9301c40c41601db5ba145add0e698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/source_map_stack_trace.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-07-27 19:18:49 UTC) #1
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-07-27 19:54:14 UTC) #2
nweiz
4 years, 4 months ago (2016-07-27 20:09:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d7c617052d9301c40c41601db5ba145add0e698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698