lib/source_map_stack_trace.dart - Issue 2187043003: Fix a crashing bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/source_map_stack_trace.dart

Issue 2187043003: Fix a crashing bug. (Closed) Base URL: git@github.com:dart-lang/source_map_stack_trace.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/source_map_stack_trace.dart

diff --git a/lib/source_map_stack_trace.dart b/lib/source_map_stack_trace.dart

index 63c5a7a7a92bed3097fc9c1b51830d421c43b1fe..5d6664c5c3a096c6eb1a10cf2c4275c52b06af41 100644

--- a/lib/source_map_stack_trace.dart

+++ b/lib/source_map_stack_trace.dart

@@ -76,7 +76,7 @@ StackTrace mapStackTrace(Mapping sourceMap, StackTrace stackTrace,

p.url.isWithin(packageResolver.packageRoot.toString(), sourceUrl)) {

sourceUrl = "package:" + p.url.relative(sourceUrl,

from: packageResolver.packageRoot.toString());

- } else {

+ } else if (packageResolver.packageConfig != null) {

for (var package in packageResolver.packageConfigMap.keys) {

var packageUrl = packageResolver.packageConfigMap[package].toString();

if (!p.url.isWithin(packageUrl, sourceUrl)) continue;

« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »