Issue 217323006: Redo allocationprofile options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217323006: Redo allocationprofile options (Closed)

Created:
6 years, 8 months ago by Cutch

Modified:
6 years, 8 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Redo allocationprofile options BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=34620

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -14 lines)			Patch
M	runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/json_stream.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/json_stream.cc	View	1 2	2 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/json_test.cc	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2	1 chunk	+23 lines, -13 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm w/ 1 weird comment. https://codereview.chromium.org/217323006/diff/20001/runtime/vm/json_stream.cc File runtime/vm/json_stream.cc (right): https://codereview.chromium.org/217323006/diff/20001/runtime/vm/json_stream.cc#newcode153 runtime/vm/json_stream.cc:153: } Consider adding a ...

6 years, 8 months ago (2014-04-01 20:23:28 UTC) #1

Cutch

https://codereview.chromium.org/217323006/diff/20001/runtime/vm/json_stream.cc File runtime/vm/json_stream.cc (right): https://codereview.chromium.org/217323006/diff/20001/runtime/vm/json_stream.cc#newcode153 runtime/vm/json_stream.cc:153: } On 2014/04/01 20:23:28, turnidge wrote: > Consider adding ...

6 years, 8 months ago (2014-04-01 22:01:13 UTC) #2

Cutch

6 years, 8 months ago (2014-04-01 22:05:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r34620 (presubmit successful).

Expand Messages | Collapse Messages

Issue 217323006: Redo allocationprofile options (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages