Redo allocationprofile options

runtime/vm/json_stream.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/json_stream.h"
 #include "vm/message.h"
@@ skipping 121 matching lines @@
 const char* JSONStream::LookupOption(const char* key) const {
   for (int i = 0; i < num_options(); i++) {
     if (!strcmp(key, option_keys_[i])) {
       return option_values_[i];
     }
   }
   return NULL;
 }
 
 
+bool JSONStream::HasOption(const char* key) const {
+  ASSERT(key);
+  return LookupOption(key) != NULL;
+}
+
+
+bool JSONStream::OptionIs(const char* key, const char* value) const {
+  ASSERT(key);
+  ASSERT(value);
+  const char* key_value = LookupOption(key);
+  return (key_value != NULL) && (strcmp(key_value, value) == 0);
+}

[turnidge, 2014/04/01 20:23:28]

Consider adding a heartbeat unit test for these two new functions.

[Cutch, 2014/04/01 22:01:14]

Added a test for options and arguments in JSONStream (see json_test.cc for a
bunch of JSONStream tests).

+
+
 void JSONStream::Clear() {
   buffer_.Clear();
   open_objects_ = 0;
 }
 
 
 void JSONStream::OpenObject(const char* property_name) {
   PrintCommaIfNeeded();
   open_objects_++;
   if (property_name != NULL) {
@@ skipping 250 matching lines @@
   intptr_t len2 = OS::VSNPrint(p, len+1, format, args);
   va_end(args);
   ASSERT(len == len2);
   stream_->buffer_.AddChar('"');
   stream_->AddEscapedUTF8String(p);
   stream_->buffer_.AddChar('"');
   free(p);
 }
 
 }  // namespace dart