Issue 217233002: minor fixes in custom_element so we can publish it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217233002: minor fixes in custom_element so we can publish it. (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

minor fixes in custom_element so we can publish it. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34518

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	pkg/custom_element/lib/custom_element.dart	View		3 chunks	+3 lines, -4 lines	1 comment	Download
	M	pkg/custom_element/pubspec.yaml	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/217233002/diff/1/pkg/custom_element/lib/custom_element.dart File pkg/custom_element/lib/custom_element.dart (right): https://codereview.chromium.org/217233002/diff/1/pkg/custom_element/lib/custom_element.dart#newcode122 pkg/custom_element/lib/custom_element.dart:122: void setAttributeNS( FYI - analyzer tests seem to report ...

6 years, 9 months ago (2014-03-28 16:51:17 UTC) #1

Siggi Cherem (dart-lang)

6 years, 9 months ago (2014-03-28 19:59:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34518 (presubmit successful).

Expand Messages | Collapse Messages