Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: pkg/custom_element/lib/custom_element.dart

Issue 217233002: minor fixes in custom_element so we can publish it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/custom_element/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/custom_element/lib/custom_element.dart
diff --git a/pkg/custom_element/lib/custom_element.dart b/pkg/custom_element/lib/custom_element.dart
index 9370cb364f6d040713adb4e6707c930efb61563a..b0a3b5b876efb7f3eb1436f23dd269ddf649210b 100644
--- a/pkg/custom_element/lib/custom_element.dart
+++ b/pkg/custom_element/lib/custom_element.dart
@@ -17,9 +17,8 @@
*/
library custom_element;
-import 'dart:async';
import 'dart:html';
-import 'src/custom_tag_name.dart';
+import 'dart:async';
/**
* *Deprecated* -- do not use. Extend [HtmlElement] and use
@@ -120,7 +119,7 @@ class CustomElement implements Element {
host.getAttributeNS(namespaceUri, localName);
@deprecated
- String setAttributeNS(
+ void setAttributeNS(
Siggi Cherem (dart-lang) 2014/03/28 16:51:17 FYI - analyzer tests seem to report some but not a
String namespaceUri, String localName, String value) {
host.setAttributeNS(namespaceUri, localName, value);
}
@@ -144,7 +143,7 @@ class CustomElement implements Element {
/**
* Replaces this node with another node.
*/
- Node replaceWith(Node otherNode) { host.replaceWith(otherNode); }
+ Node replaceWith(Node otherNode) => host.replaceWith(otherNode);
/**
* Removes this node from the DOM.
« no previous file with comments | « no previous file | pkg/custom_element/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698