Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171743003: Add the package implementation. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
jakemac, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf_packages_handler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -3 lines) Patch
M CONTRIBUTING.md View 1 1 chunk +1 line, -1 line 0 comments Download
M LICENSE View 1 1 chunk +1 line, -1 line 0 comments Download
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
A lib/shelf_packages_handler.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
A lib/src/async_handler.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A lib/src/dir_handler.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download
A lib/src/package_config_handler.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 chunks +8 lines, -1 line 0 comments Download
A test/packages_handler_test.dart View 1 1 chunk +147 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nweiz
4 years, 5 months ago (2016-07-21 21:32:40 UTC) #1
jakemac
lgtm https://codereview.chromium.org/2171743003/diff/1/lib/src/dir_handler.dart File lib/src/dir_handler.dart (right): https://codereview.chromium.org/2171743003/diff/1/lib/src/dir_handler.dart#newcode1 lib/src/dir_handler.dart:1: // Copyright (c) 2015, the Dart project authors. ...
4 years, 5 months ago (2016-07-21 21:45:57 UTC) #2
kevmoo
DBC https://codereview.chromium.org/2171743003/diff/1/lib/src/package_config_handler.dart File lib/src/package_config_handler.dart (right): https://codereview.chromium.org/2171743003/diff/1/lib/src/package_config_handler.dart#newcode15 lib/src/package_config_handler.dart:15: /// The static handlers for serving entries in ...
4 years, 5 months ago (2016-07-21 21:55:07 UTC) #4
nweiz
Code review changes
4 years, 5 months ago (2016-07-21 23:07:11 UTC) #5
nweiz
https://codereview.chromium.org/2171743003/diff/1/lib/src/dir_handler.dart File lib/src/dir_handler.dart (right): https://codereview.chromium.org/2171743003/diff/1/lib/src/dir_handler.dart#newcode1 lib/src/dir_handler.dart:1: // Copyright (c) 2015, the Dart project authors. Please ...
4 years, 5 months ago (2016-07-21 23:07:24 UTC) #6
nweiz
4 years, 5 months ago (2016-07-21 23:08:15 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4dd6a3ec92a3f0342bb44cf674b4c5c5d87dcc80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698