Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Side by Side Diff: CONTRIBUTING.md

Issue 2171743003: Add the package implementation. (Closed) Base URL: git@github.com:dart-lang/shelf_packages_handler.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LICENSE » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Want to contribute? Great! First, read this page (including the small print at 1 Want to contribute? Great! First, read this page (including the small print at
2 the end). 2 the end).
3 3
4 ### Before you contribute 4 ### Before you contribute
5 Before we can use your code, you must sign the 5 Before we can use your code, you must sign the
6 [Google Individual Contributor License Agreement](https://cla.developers.google. com/about/google-individual) 6 [Google Individual Contributor License Agreement](https://cla.developers.google. com/about/google-individual)
7 (CLA), which you can do online. The CLA is necessary mainly because you own the 7 (CLA), which you can do online. The CLA is necessary mainly because you own the
8 copyright to your changes, even after your contribution becomes part of our 8 copyright to your changes, even after your contribution becomes part of our
9 codebase, so we need your permission to use and distribute your code. We also 9 codebase, so we need your permission to use and distribute your code. We also
10 need to be sure of various other things—for instance that you'll tell us if you 10 need to be sure of various other things—for instance that you'll tell us if you
11 know that your code infringes on other people's patents. You don't have to sign 11 know that your code infringes on other people's patents. You don't have to sign
12 the CLA until after you've submitted your code for review and a member has 12 the CLA until after you've submitted your code for review and a member has
13 approved it, but you must do it before we can put your code into our codebase. 13 approved it, but you must do it before we can put your code into our codebase.
14 14
15 Before you start working on a larger contribution, you should get in touch with 15 Before you start working on a larger contribution, you should get in touch with
16 us first through the issue tracker with your idea so that we can help out and 16 us first through the issue tracker with your idea so that we can help out and
17 possibly guide you. Coordinating up front makes it much easier to avoid 17 possibly guide you. Coordinating up front makes it much easier to avoid
18 frustration later on. 18 frustration later on.
19 19
20 ### Code reviews 20 ### Code reviews
21 All submissions, including submissions by project members, require review. 21 All submissions, including submissions by project members, require review.
22 22
23 ### File headers 23 ### File headers
24 All files in the project must start with the following header. 24 All files in the project must start with the following header.
25 25
26 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS fil e 26 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS fil e
27 // for details. All rights reserved. Use of this source code is governed by a 27 // for details. All rights reserved. Use of this source code is governed by a
28 // BSD-style license that can be found in the LICENSE file. 28 // BSD-style license that can be found in the LICENSE file.
29 29
30 ### The small print 30 ### The small print
31 Contributions made by corporations are covered by a different agreement than the 31 Contributions made by corporations are covered by a different agreement than the
32 one above, the 32 one above, the
33 [Software Grant and Corporate Contributor License Agreement](https://developers. google.com/open-source/cla/corporate). 33 [Software Grant and Corporate Contributor License Agreement](https://developers. google.com/open-source/cla/corporate).
OLDNEW
« no previous file with comments | « no previous file | LICENSE » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698