Issue 216603010: Rip out dart:io from pkg/http wherever possible.

Issue 216603010: Rip out dart:io from pkg/http wherever possible. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rip out dart:io from pkg/http wherever possible. This uses the http_parser package instead of dart:io's ContentType, ByteConversionSink instead of ByteBuffer, and a new ClientException type instead of HttpException. This still uses dart:io for the default Client implementation and for [MultipartFile.fromPath]. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=34716

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -105 lines)			Patch
M	pkg/http/CHANGELOG.md	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/http/lib/http.dart	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/http/lib/src/base_client.dart	View		5 chunks	+7 lines, -5 lines	0 comments	Download
M	pkg/http/lib/src/byte_stream.dart	View		2 chunks	+9 lines, -7 lines	0 comments	Download
M	pkg/http/lib/src/client.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	pkg/http/lib/src/exception.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	pkg/http/lib/src/io_client.dart	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/http/lib/src/multipart_file.dart	View		5 chunks	+11 lines, -15 lines	0 comments	Download
M	pkg/http/lib/src/multipart_request.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/request.dart	View		6 chunks	+24 lines, -29 lines	0 comments	Download
M	pkg/http/lib/src/response.dart	View		2 chunks	+10 lines, -8 lines	0 comments	Download
M	pkg/http/lib/src/utils.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/http/pubspec.yaml	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/http/test/http_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/http/test/multipart_test.dart	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/http/test/utils.dart	View		2 chunks	+3 lines, -11 lines	0 comments	Download
M	pkg/oauth2/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/oauth2/lib/src/handle_access_token_response.dart	View		3 chunks	+6 lines, -10 lines	0 comments	Download
M	pkg/oauth2/pubspec.yaml	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/bin/pub.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View		4 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Update the pubspec then LGTM! https://codereview.chromium.org/216603010/diff/1/pkg/http/pubspec.yaml File pkg/http/pubspec.yaml (right): https://codereview.chromium.org/216603010/diff/1/pkg/http/pubspec.yaml#newcode8 pkg/http/pubspec.yaml:8: stack_trace: ">=0.9.1 <0.10.0" http_parser

6 years, 8 months ago (2014-04-03 16:54:28 UTC) #2

nweiz

https://codereview.chromium.org/216603010/diff/1/pkg/http/pubspec.yaml File pkg/http/pubspec.yaml (right): https://codereview.chromium.org/216603010/diff/1/pkg/http/pubspec.yaml#newcode8 pkg/http/pubspec.yaml:8: stack_trace: ">=0.9.1 <0.10.0" On 2014/04/03 16:54:28, Bob Nystrom wrote: ...

6 years, 8 months ago (2014-04-03 18:28:34 UTC) #3

nweiz

6 years, 8 months ago (2014-04-03 18:29:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34716 (presubmit successful).

Expand Messages | Collapse Messages