Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: pkg/http/lib/http.dart

Issue 216603010: Rip out dart:io from pkg/http wherever possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/http/CHANGELOG.md ('k') | pkg/http/lib/src/base_client.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/http/lib/http.dart
diff --git a/pkg/http/lib/http.dart b/pkg/http/lib/http.dart
index 2b76f8d0a7c6b70f5b1c99fce20b4af43a146e85..67c56496079297bc2449522e8983ec6200d98b14 100644
--- a/pkg/http/lib/http.dart
+++ b/pkg/http/lib/http.dart
@@ -59,7 +59,7 @@
/// UserAgentClient(this.userAgent, this._inner);
///
/// Future<StreamedResponse> send(BaseRequest request) {
-/// request.headers[HttpHeaders.USER_AGENT] = userAgent;
+/// request.headers['user-agent'] = userAgent;
/// return _inner.send(request);
/// }
/// }
@@ -79,6 +79,7 @@ export 'src/base_request.dart';
export 'src/base_response.dart';
export 'src/byte_stream.dart';
export 'src/client.dart';
+export 'src/exception.dart';
export 'src/multipart_file.dart';
export 'src/multipart_request.dart';
export 'src/request.dart';
@@ -171,7 +172,7 @@ Future<Response> delete(url, {Map<String, String> headers}) =>
/// be a [Uri] or a [String], and returns a Future that completes to the body of
/// the response as a [String].
///
-/// The Future will emit an [HttpException] if the response doesn't have a
+/// The Future will emit a [ClientException] if the response doesn't have a
/// success status code.
///
/// This automatically initializes a new [Client] and closes that client once
@@ -187,7 +188,7 @@ Future<String> read(url, {Map<String, String> headers}) =>
/// be a [Uri] or a [String], and returns a Future that completes to the body of
/// the response as a list of bytes.
///
-/// The Future will emit an [HttpException] if the response doesn't have a
+/// The Future will emit a [ClientException] if the response doesn't have a
/// success status code.
///
/// This automatically initializes a new [Client] and closes that client once
« no previous file with comments | « pkg/http/CHANGELOG.md ('k') | pkg/http/lib/src/base_client.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698