Pub's listDir shouldn't fail when called within hidden directories.

Pub's listDir shouldn't fail when called within hidden directories.

R=rnystrom@google.com
BUG=17861
Committed: https://code.google.com/p/dart/source/detail?r=34489

[nweiz, 2014-03-27 23:42:09]

TBR

[nweiz, 2014-03-27 23:42:22]

Committed patchset #1 manually as r34489 (presubmit successful).

[Bob Nystrom, 2014-03-28 15:42:07]

Thank you for tracking this down!

https://codereview.chromium.org/215503004/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/215503004/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:260: assert(entity.path.startsWith(dir));
I worry this will fail because of canonicalization. Is there a reason you don't
use path.relative() instead of substring?

[nweiz, 2014-03-31 19:13:32]

https://codereview.chromium.org/215503004/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/215503004/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:260: assert(entity.path.startsWith(dir));
On 2014/03/28 15:42:07, Bob Nystrom wrote:
> I worry this will fail because of canonicalization. Is there a reason you
don't
> use path.relative() instead of substring?

[Directory.list] guarantees that it will return paths that begin with [dir]. I
didn't want to use [path.relative] because this is an inner loop that's
historically been a performance pain point, so I wanted to minimize the amount
of parsing and processing that had to happen.

[Bob Nystrom, 2014-03-31 20:04:25]

LGTM.