Pub's listDir shouldn't fail when called within hidden directories.

sdk/lib/_internal/pub/lib/src/io.dart

Index: sdk/lib/_internal/pub/lib/src/io.dart
diff --git a/sdk/lib/_internal/pub/lib/src/io.dart b/sdk/lib/_internal/pub/lib/src/io.dart
index d50e06860ae40981b4ab0e2ce948c5301fe13809..b054a770d1157370cf1428e9f3a3ffd7b9a2c4d9 100644
--- a/sdk/lib/_internal/pub/lib/src/io.dart
+++ b/sdk/lib/_internal/pub/lib/src/io.dart
@@ -256,8 +256,10 @@ List<String> listDir(String dir, {bool recursive: false,
   isHidden(part) => part.startsWith(".") && part != "." && part != "..";
 
   if (!includeHidden) {
-    entities = entities.where(
-        (entity) => !path.split(entity.path).any(isHidden));
+    entities = entities.where((entity) {
+      assert(entity.path.startsWith(dir));

[Bob Nystrom, 2014/03/28 15:42:07]

I worry this will fail because of canonicalization. Is there a reason you don't
use path.relative() instead of substring?

[nweiz, 2014/03/31 19:13:32]

[Directory.list] guarantees that it will return paths that begin with [dir]. I
didn't want to use [path.relative] because this is an inner loop that's
historically been a performance pain point, so I wanted to minimize the amount
of parsing and processing that had to happen.

+      return !path.split(entity.path.substring(dir.length + 1)).any(isHidden);
+    });
   }
 
   return entities.map((entity) => entity.path).toList();