Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 214723002: Remove unmodifiable map wrappers that could instead use UnmodifiableMapView. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, kevmoo, Johnni Winther
Visibility:
Public.

Description

Remove unmodifiable map wrappers that could instead use UnmodifiableMapView. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35244 Committed: https://code.google.com/p/dart/source/detail?r=35361

Patch Set 1 #

Patch Set 2 : Fix missing import, increment mirror function count. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -168 lines) Patch
M pkg/template_binding/test/custom_element_bindings_test.dart View 1 2 chunks +5 lines, -20 lines 0 comments Download
M pkg/yaml/lib/src/yaml_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/mirrors_impl.dart View 7 chunks +8 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/util.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 2 chunks +2 lines, -40 lines 0 comments Download
M sdk/lib/core/uri.dart View 2 chunks +1 line, -31 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 5 chunks +11 lines, -39 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
6 years, 9 months ago (2014-03-27 13:56:45 UTC) #1
Lasse Reichstein Nielsen
PTAL
6 years, 8 months ago (2014-04-11 12:43:08 UTC) #2
Søren Gjesse
lgtm
6 years, 8 months ago (2014-04-11 14:34:55 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 manually as r35244 (presubmit successful).
6 years, 8 months ago (2014-04-22 05:53:48 UTC) #4
Lasse Reichstein Nielsen
Reverted. It triggers a bug in dart2js. Will recommit when that is fixed.
6 years, 8 months ago (2014-04-22 07:43:38 UTC) #5
Lasse Reichstein Nielsen
6 years, 8 months ago (2014-04-24 08:51:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r35361 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698