sdk/lib/_internal/compiler/implementation/mirrors/util.dart - Issue 214723002: Remove unmodifiable map wrappers that could instead use UnmodifiableMapView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/util.dart

Issue 214723002: Remove unmodifiable map wrappers that could instead use UnmodifiableMapView. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix missing import, increment mirror function count. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/mirrors/util.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/util.dart b/sdk/lib/_internal/compiler/implementation/mirrors/util.dart

index 7d9ad7766f40ae5c940918c129ae3ff2c728c823..2ea4638c6b9d0647c5ab191bc3ce1e10f546e0fe 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/util.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/util.dart

@@ -12,6 +12,8 @@ import 'dart:collection' show Maps;

* [:operator []:], [:forEach:] and [:length:] methods to provide a fully

* implemented immutable map.

+// TODO(lrn): Consider using UnmodifiableBaseMap/UnmodifiableMapWrapper

+// for these classes, or just rewrite for a bit more efficiency.

abstract class AbstractMap<K, V> implements Map<K, V> {

AbstractMap();

« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »