Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 214673002: Handle cascade in type checker. (Closed)

Created:
6 years, 9 months ago by Johnni Winther
Modified:
6 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle cascade in type checker. BUG=http://dartbug.com/17803 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=34585

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 chunk +0 lines, -5 lines 2 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +168 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
6 years, 9 months ago (2014-03-27 12:58:11 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/214673002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (left): https://codereview.chromium.org/214673002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#oldcode514 sdk/lib/_internal/compiler/implementation/typechecker.dart:514: if (node.expression.asCascadeReceiver() == null) { (If I remember ...
6 years, 8 months ago (2014-03-31 14:13:39 UTC) #2
Johnni Winther
https://codereview.chromium.org/214673002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (left): https://codereview.chromium.org/214673002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#oldcode514 sdk/lib/_internal/compiler/implementation/typechecker.dart:514: if (node.expression.asCascadeReceiver() == null) { On 2014/03/31 14:13:40, karlklose ...
6 years, 8 months ago (2014-04-01 06:45:05 UTC) #3
Johnni Winther
6 years, 8 months ago (2014-04-01 07:01:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r34585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698