Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: sdk/lib/_internal/compiler/implementation/typechecker.dart

Issue 214673002: Handle cascade in type checker. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/type_checker_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/typechecker.dart
diff --git a/sdk/lib/_internal/compiler/implementation/typechecker.dart b/sdk/lib/_internal/compiler/implementation/typechecker.dart
index c52c9fe1099e98ac560df201a32fb26e6779f517..f11266884cce4c87f7b69558ea5c7a7f0e9c0d96 100644
--- a/sdk/lib/_internal/compiler/implementation/typechecker.dart
+++ b/sdk/lib/_internal/compiler/implementation/typechecker.dart
@@ -511,11 +511,6 @@ class TypeCheckerVisitor extends Visitor<DartType> {
DartType visitCascade(Cascade node) {
analyze(node.expression);
- if (node.expression.asCascadeReceiver() == null) {
karlklose 2014/03/31 14:13:40 (If I remember correctly, I added this because of
Johnni Winther 2014/04/01 06:45:05 Never! [expression] is always a send.
- // TODO(karlklose): bug: expressions of the form e..x = y do not have
- // a CascadeReceiver as expression currently.
- return types.dynamicType;
- }
return popCascadeType();
}
« no previous file with comments | « no previous file | tests/compiler/dart2js/type_checker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698