Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 214253002: Translate Java enums to Dart constants. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Translate Java enums to Dart constants. 1. Restore "this.field" field formal initializers. 2. Tweaks for several Java places - mostly to the constructors; but also duplicate HintCode messages (in Dart we cannot get values of constant values final fields). 3. Translate field that are not written to Dart final fields and also to field initializers, even if there are no property for them. 4. And constant enums. 5. pkg/code_transformers/test/resolver_test has to be skipped, I cannot fix it myself. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34474

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1992 lines, -2491 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java View 4 chunks +8 lines, -9 lines 1 comment Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HintCode.java View 6 chunks +7 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/HtmlWarningCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/PubSuggestionCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/ResolvableCompilationUnit.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ParserErrorCode.java View 4 chunks +9 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/resolver/ResolverErrorCode.java View 1 chunk +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/ScannerErrorCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/TokenType.java View 5 chunks +17 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/error/GatheringErrorListener.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/EnclosedScopeTest.java View 3 chunks +6 lines, -6 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 2 chunks +3 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 4 chunks +11 lines, -5 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/LocalVariablesSemanticProcessor.java View 1 chunk +4 lines, -0 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java View 8 chunks +54 lines, -6 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 6 chunks +23 lines, -24 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/PropertySemanticProcessorTest.java View 4 chunks +74 lines, -28 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 96 chunks +104 lines, -282 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 32 chunks +53 lines, -93 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 37 chunks +103 lines, -149 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 118 chunks +368 lines, -404 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 177 chunks +363 lines, -425 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 26 chunks +47 lines, -87 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 24 chunks +52 lines, -94 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 12 chunks +157 lines, -189 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 82 chunks +173 lines, -230 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 34 chunks +184 lines, -249 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 14 chunks +40 lines, -40 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 8 chunks +18 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 2 chunks +19 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 10 chunks +53 lines, -30 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 9 months ago (2014-03-27 04:29:55 UTC) #1
Brian Wilkerson
LGTM! Based on the lack of changes to client code I assume that this doesn't ...
6 years, 9 months ago (2014-03-27 15:15:18 UTC) #2
scheglov
Committed patchset #1 manually as r34474 (presubmit successful).
6 years, 9 months ago (2014-03-27 15:37:54 UTC) #3
blois
6 years, 9 months ago (2014-03-27 16:42:36 UTC) #4
Message was sent while issue was closed.
A number of problems here that I consider quite serious and would like to see
this CL reverted:
- the code_transformers test is covering core functionality that we're basing a
bunch of libraries off of, including Angular, Polymer and DI. This test breaking
is a very (very) bad sign.
- The specific breakage appears to be related to incremental updating of the
analyzer not removing deleted libraries. This seems like an actual Analyzer
issue.
- pubspec.yaml was updated with a compatible version number- the fact that tests
broke is an indication that this change is not backwards compatible.

Powered by Google App Engine
This is Rietveld 408576698