Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java

Issue 214253002: Translate Java enums to Dart constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java
index 52cf84424af9f40ae12ae49585df77f630130e77..8381d6d9077dab2086a509edf4aa56f3f7141b92 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/AngularCode.java
@@ -19,15 +19,14 @@ package com.google.dart.engine.error;
public enum AngularCode implements ErrorCode {
CANNOT_PARSE_SELECTOR("The selector '%s' cannot be parsed"),
INVALID_PROPERTY_KIND(
- "Unknown property binding kind '%s', use one of the '@', '=>', '=>!' or '<=>'",
- ErrorSeverity.ERROR),
+ "Unknown property binding kind '%s', use one of the '@', '=>', '=>!' or '<=>'"),
INVALID_PROPERTY_FIELD("Unknown property field '%s'"),
INVALID_PROPERTY_MAP("Argument 'map' must be a constant map literal"),
INVALID_PROPERTY_NAME("Property name must be a string literal"),
INVALID_PROPERTY_SPEC("Property binding specification must be a string literal"),
INVALID_REPEAT_SYNTAX("Expected statement in form '_item_ in _collection_ [tracked by _id_]'"),
INVALID_REPEAT_ITEM_SYNTAX("Item must by identifier or in '(_key_, _value_)' pair."),
- INVALID_URI("Invalid URI syntax: '%s'", ErrorSeverity.ERROR),
+ INVALID_URI("Invalid URI syntax: '%s'"),
MISSING_FILTER_COLON("Missing ':' before filter argument"),
MISSING_NAME("Argument 'name' must be provided"),
MISSING_PUBLISH_AS("Argument 'publishAs' must be provided"),
@@ -42,7 +41,7 @@ public enum AngularCode implements ErrorCode {
/**
* The severity of the problem.
*/
- private final ErrorSeverity severity;
+ private final ErrorSeverity errorSeverity;
Brian Wilkerson 2014/03/27 15:15:19 Do we still need/want this field? As far as I can
/**
* Initialize a newly created error code to have the given message.
@@ -50,18 +49,18 @@ public enum AngularCode implements ErrorCode {
* @param message the message template used to create the message to be displayed for the error
*/
private AngularCode(String message) {
- this(message, ErrorSeverity.WARNING);
+ this(message, ErrorSeverity.INFO);
}
/**
* Initialize a newly created error code to have the given message.
*
* @param message the message template used to create the message to be displayed for the error
- * @param severity the severity of the problem
+ * @param errorSeverity the severity of the problem
*/
- private AngularCode(String message, ErrorSeverity severity) {
+ private AngularCode(String message, ErrorSeverity errorSeverity) {
this.message = message;
- this.severity = ErrorSeverity.INFO; //severity;
+ this.errorSeverity = errorSeverity;
}
@Override
@@ -71,7 +70,7 @@ public enum AngularCode implements ErrorCode {
@Override
public ErrorSeverity getErrorSeverity() {
- return severity;
+ return errorSeverity;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698