Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 21307004: Implement some conditional moves instructions for ia32/x64. Use them in MinMax instruction implemen… (Closed)

Created:
7 years, 4 months ago by srdjan
Modified:
7 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implement some conditional moves instructions for ia32/x64. Use them in MinMax instruction implementation. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -11 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 4 months ago (2013-07-31 00:06:26 UTC) #1
Cutch
LGTM assuming there are tests which trigger these inlines.
7 years, 4 months ago (2013-07-31 00:13:57 UTC) #2
srdjan
7 years, 4 months ago (2013-07-31 22:57:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25685 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698