runtime/vm/intermediate_language_x64.cc - Issue 21307004: Implement some conditional moves instructions for ia32/x64. Use them in MinMax instruction implemen…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 21307004: Implement some conditional moves instructions for ia32/x64. Use them in MinMax instruction implemen… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

===================================================================

--- runtime/vm/intermediate_language_x64.cc (revision 25648)

+++ runtime/vm/intermediate_language_x64.cc (working copy)

@@ -3814,7 +3814,6 @@

return;

}

- Label done;

ASSERT(result_cid() == kSmiCid);

@@ -3822,12 +3821,10 @@

__ cmpq(left, right);

ASSERT(result == left);

if (is_min) {

- __ j(LESS_EQUAL, &done, Assembler::kNearJump);

+ __ cmovgeq(result, right);

} else {

- __ j(GREATER_EQUAL, &done, Assembler::kNearJump);

+ __ cmovlessq(result, right);

}

- __ movq(result, right);

- __ Bind(&done);

}

« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »