Issue 212823002: Don't loop forever on scanner errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212823002: Don't loop forever on scanner errors. (Closed)

Created:
6 years, 9 months ago by ahe

Modified:
6 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't loop forever on scanner errors. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=34426

Patch Set 2 : Fix long line that Kasper missed :-) #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -14 lines)			Patch
	M	dart/site/try/src/interaction_manager.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	dart/tests/try/paste_content_rewriting_test.dart	View	1	1 chunk	+45 lines, -14 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Thank you, Kasper! https://codereview.chromium.org/212823002/diff/50001/dart/tests/try/paste_content_rewriting_test.dart File dart/tests/try/paste_content_rewriting_test.dart (right): https://codereview.chromium.org/212823002/diff/50001/dart/tests/try/paste_content_rewriting_test.dart#newcode74 dart/tests/try/paste_content_rewriting_test.dart:74: mainEditorPane, childList: true, characterData: true, subtree: ...

6 years, 9 months ago (2014-03-26 12:45:05 UTC) #3

ahe

6 years, 9 months ago (2014-03-26 12:46:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34426 (presubmit successful).

Expand Messages | Collapse Messages

Issue 212823002: Don't loop forever on scanner errors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix long line that Kasper missed :-) #

Messages