dart/site/try/src/interaction_manager.dart - Issue 212823002: Don't loop forever on scanner errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/site/try/src/interaction_manager.dart

Issue 212823002: Don't loop forever on scanner errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix long line that Kasper missed :-) Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/site/try/src/interaction_manager.dart

diff --git a/dart/site/try/src/interaction_manager.dart b/dart/site/try/src/interaction_manager.dart

index 431dbe870008e1b58207872d569c92fc99d773a0..0f0a18c7da5b36c0a3c74d9f8818065703fb1035 100644

--- a/dart/site/try/src/interaction_manager.dart

+++ b/dart/site/try/src/interaction_manager.dart

@@ -260,6 +260,7 @@ class InitialState extends InteractionState {

selectionOffset = selection.anchorOffset;

}

int splitPoint = token.charOffset - offset;

+ if (splitPoint < 0) continue; // Happens for scanner errors.

Text str = node.splitText(splitPoint);

Text after = str.splitText(token.charCount);

offset += splitPoint + token.charCount;