Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 21274007: Set local function type as uninstantiated when applicable (fix issue 12127). (Closed)

Created:
7 years, 4 months ago by regis
Modified:
7 years, 4 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org, zra
Visibility:
Public.

Description

Set local function type as uninstantiated when applicable (fix issue 12127). Add language regression test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=25687

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +4 lines, -0 lines 2 comments Download
A tests/language/function_subtype_local6_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
regis
7 years, 4 months ago (2013-07-31 18:57:48 UTC) #1
zra
https://codereview.chromium.org/21274007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/21274007/diff/1/runtime/vm/parser.cc#newcode5372 runtime/vm/parser.cc:5372: // The function type was initially marked as instantiated, ...
7 years, 4 months ago (2013-07-31 21:32:32 UTC) #2
regis
https://codereview.chromium.org/21274007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/21274007/diff/1/runtime/vm/parser.cc#newcode5372 runtime/vm/parser.cc:5372: // The function type was initially marked as instantiated, ...
7 years, 4 months ago (2013-07-31 23:16:44 UTC) #3
zra
lgtm
7 years, 4 months ago (2013-07-31 23:18:36 UTC) #4
regis
Committed patchset #1 manually as r25687 (presubmit successful).
7 years, 4 months ago (2013-07-31 23:26:33 UTC) #5
Florian Schneider
7 years, 4 months ago (2013-08-01 10:33:04 UTC) #6
Message was sent while issue was closed.
On 2013/07/31 23:26:33, regis wrote:
> Committed patchset #1 manually as r25687 (presubmit successful).

Thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698