Issue 212193002: Don't use ThreadSignalBlocker in mac eventhandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212193002: Don't use ThreadSignalBlocker in mac eventhandler. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
ricow1, Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't use ThreadSignalBlocker in mac eventhandler. Turns out kevent can modify the current sigmask. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34408

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	runtime/bin/eventhandler_macos.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	runtime/bin/eventhandler_macos.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

ricow1

Rubberstamp LGTM (I don't really know anything about this)

6 years, 9 months ago (2014-03-26 06:16:51 UTC) #2

Anders Johnsen

Committed patchset #1 manually as r34408 (presubmit successful).

6 years, 9 months ago (2014-03-26 06:21:46 UTC) #3

Søren Gjesse

6 years, 9 months ago (2014-03-26 07:34:22 UTC) #4

Message was sent while issue was closed.

lgtm - another reason for using some other kind of signal blocker in-scope
check.