runtime/bin/eventhandler_macos.h - Issue 212193002: Don't use ThreadSignalBlocker in mac eventhandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_macos.h

Issue 212193002: Don't use ThreadSignalBlocker in mac eventhandler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_macos.h

diff --git a/runtime/bin/eventhandler_macos.h b/runtime/bin/eventhandler_macos.h

index 4ea1a0150cd4489af6d816434234557c0eb3e281..4e32dc0656f159b44e50d34b16240d075a38b116 100644

--- a/runtime/bin/eventhandler_macos.h

+++ b/runtime/bin/eventhandler_macos.h

@@ -43,13 +43,6 @@ class SocketData {

bool HasReadEvent();

bool HasWriteEvent();

- void Close() {

- port_ = 0;

- mask_ = 0;

- VOID_TEMP_FAILURE_RETRY(close(fd_));

- fd_ = -1;

- }

bool IsListeningSocket() { return (mask_ & (1 << kListeningSocket)) != 0; }

void SetPortAndMask(Dart_Port port, intptr_t mask) {

« no previous file with comments | « no previous file | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »