Issue 211373005: Add fullgc sub-command to allocationprofile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211373005: Add fullgc sub-command to allocationprofile (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
turnidge, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add fullgc subcommand to allocationprofile BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34390

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	runtime/vm/service.cc	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -IP https://codereview.chromium.org/211373005/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/211373005/diff/1/runtime/vm/service.cc#newcode1464 runtime/vm/service.cc:1464: } else if (!strcmp(sub_command, "fullgc")) { We ...

6 years, 9 months ago (2014-03-25 21:20:43 UTC) #2

Cutch

Committed patchset #1 manually as r34390 (presubmit successful).

6 years, 9 months ago (2014-03-25 21:28:50 UTC) #3

turnidge

6 years, 9 months ago (2014-03-25 22:02:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/211373005/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/211373005/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1464: } else if (!strcmp(sub_command, "fullgc")) {
On 2014/03/25 21:20:43, Ivan Posva wrote:
> We need a better way to pass parameters to  the different service invocations.
> Not in this CL.

This feels more like an option than a subcommand to me:

/isolates/foo/allocationprofile?gc=true

Do you agree?

Expand Messages | Collapse Messages